Skip to content

improv(ci): Inherited the secrets for update ssm workflow #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

improv(ci): Inherited the secrets for update ssm workflow #4388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e04d472
Inherited the secrets for update ssm workflow
sdangol Aug 26, 2025
e16d54c
Updated the excemption message for using inherit
sdangol Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/make-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,8 @@ jobs:
publish_layer:
needs: publish-npm
secrets:
AWS_LAYERS_BETA_ROLE_ARN: ${{ secrets.AWS_LAYERS_BETA_ROLE_ARN }}
AWS_LAYERS_PROD_ROLE_ARN: ${{ secrets.AWS_LAYERS_PROD_ROLE_ARN }}
TOKEN_GITHUB: ${{ secrets.GITHUB_TOKEN }}
# We use "inherit" because need to propagate the secrets to the reusable workflow, secrets are already scoped by using GitHub's deployment environments to mitigate the risk of secret exposure.
inherit
permissions:
id-token: write
contents: write
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish_layer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ jobs:
environment: prod
package_version: ${{ inputs.latest_published_version }}
layer-version: ${{ needs.deploy-prod.outputs.layer-version }}
secrets:
# We use "inherit" because need to propagate the secrets to the reusable workflow, secrets are already scoped by using GitHub's deployment environments to mitigate the risk of secret exposure.
inherit

update_layer_arn_docs:
needs: [deploy-prod]
Expand Down