-
Notifications
You must be signed in to change notification settings - Fork 171
feat(event-handler): add event handler registry #4307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not all issues are linked correctly. Please link each issue to the PR either manually or using a closing keyword in the format If mentioning more than one issue, separate them with commas: i.e. |
180bc8e
to
9dae641
Compare
For some reason Sonar is failing but there were findings (https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&sinceLeakPeriod=true&pullRequest=4307&id=aws-powertools_powertools-lambda-typescript) usually making another commit fixes it, I think we can address these items and it'll work. |
611beb6
to
24423ae
Compare
|
Yeah, that fixed it! |
Summary
This PR creates the error handler registry class. It follows the same pattern as the route registry by exposing
register
andresolve
methods. A very rudimentary integration with theBaseRouter
class has also been done, the next PR will fully implement that integration.Changes
ErrorHandlerRegistry
classerrorHandler()
method to BaseRouter: Allows registration of error handlers for specific error types using theErrorHandlerRegistry
BaseRouter
now instantiates and manages anErrorHandlerRegistry
Issue number: #4141
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.