-
Notifications
You must be signed in to change notification settings - Fork 171
feat(event-handler): implement route matching & resolution system for rest handler #4297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7b12124
feat(event-handler): implement route matching & resolution system for…
svozza cf5c1d9
use binary search to find insertion point in dynamic routes array
svozza dc5e10b
remove unused type
svozza 3d15064
add comment for duplicate dynamic routes
svozza ff48f73
remove unused import
svozza d3f3ee1
remove non-null operators
svozza 5b3bcba
ensure validation issue test checks error is thrown
svozza bf396a3
sort dynamic route list on first resolve
svozza 6ae818d
remove unused methods
svozza dd3d169
change param processing utility return type to record<string, string>
svozza 8a140b9
only write to dynamic route set if route does not exist
svozza 67adc85
move param processing functions to route registry class
svozza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
export class RouteMatchingError extends Error { | ||
constructor( | ||
message: string, | ||
public readonly path: string, | ||
public readonly method: string | ||
) { | ||
super(message); | ||
this.name = 'RouteMatchingError'; | ||
} | ||
} | ||
|
||
export class ParameterValidationError extends RouteMatchingError { | ||
constructor(public readonly issues: string[]) { | ||
super(`Parameter validation failed: ${issues.join(', ')}`, '', ''); | ||
this.name = 'ParameterValidationError'; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.