refactor(logger): replace EnvironmentVariablesService class with helper functions

[jaimellamasi]

Summary

Changes

This PR removes the legacy class-based EnvironmentVariablesService methods from the Logger package.

Issue number: closes #4116

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[boring-cyborg]

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

[jaimellamasi]

@dreamorosi I just pushed the changes to remove EnvironmentVariablesService from Logger. You will notice some assertion changed on the unit tests related to stack because of the behaviour of isDevMode() compared to this. envVarsService()?.isDevMode(). I am not 100% sure changes are good. I wait your feedback, thanks!

[dreamorosi]

@dreamorosi I just pushed the changes to remove EnvironmentVariablesService from Logger. You will notice some assertion changed on the unit tests related to stack because of the behaviour of isDevMode() compared to this. envVarsService()?.isDevMode(). I am not 100% sure changes are good. I wait your feedback, thanks!

Sorry, GitHub was having issues and wasn't able to engage with the PR.

I have reviewed the PR and also ran the end to end tests which are passing. I am unsure why the previous tests were passing but the current assertions look correct to me.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.5% Duplication on New Code

See analysis details on SonarQube Cloud

[dreamorosi]

Thank you so much for contributing this PR and helping making the project better for everyone!

We have a number of issues with similar complexity/scope (list), if you're interested in any of them please take a look!

[boring-cyborg]

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!