Skip to content

Conversation

sdangol
Copy link
Contributor

@sdangol sdangol commented Jul 14, 2025

Summary

This PR removes the nullable type from the md5OfMessageAttributes in the SqsRecordSchema aligning with the @types/aws-lambda package

Changes

  1. Removed the nullable type from the md5OfMessageAttributes property in the SqsRecordSchema
  2. Updated the data in firehose-sqs.json test event to remove the null value of md5OfMessageAttributes

Issue number: #4109


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jul 14, 2025
@boring-cyborg boring-cyborg bot added parser This item relates to the Parser Utility tests PRs that add or change tests labels Jul 14, 2025
Copy link

boring-cyborg bot commented Jul 14, 2025

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

Copy link

@dreamorosi dreamorosi self-requested a review July 14, 2025 12:05
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you for fixing the schema and congrats for your first PR merged in this project 🎉

@dreamorosi dreamorosi merged commit d6cbde0 into aws-powertools:main Jul 14, 2025
54 checks passed
Copy link

boring-cyborg bot commented Jul 14, 2025

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser This item relates to the Parser Utility size/XS PR between 0-9 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Ensure parser schema types are compatible with @types/aws-lambda
3 participants