Skip to content

refactor(metrics): optimize addDimensions method to avoid O(n²) complexity #4156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

refactor(metrics): optimize addDimensions method to avoid O(n²) complexity #4156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/metrics/src/Metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,8 +764,13 @@ class Metrics extends Utility implements MetricsInterface {
},
...this.defaultDimensions,
...this.dimensions,
// biome-ignore lint/performance/noAccumulatingSpread: need to merge all dimension sets
...this.dimensionSets.reduce((acc, dims) => Object.assign(acc, dims), {}),
// Merge all dimension sets efficiently by mutating the accumulator
...this.dimensionSets.reduce((acc, dims) => {
for (const [key, value] of Object.entries(dims)) {
acc[key] = value;
}
return acc;
}, {} as Dimensions),
...metricValues,
...this.metadata,
};
Expand Down
Loading