[Bug] Configs with different types (numpy vs native) are counted double #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1241 plus some flake fixes
dengdifan
reviewed
Jul 15, 2025
smac/runhistory/runhistory.py
Outdated
| Config with only pure python types. | ||
| """ | ||
| config_values = list(dict(config).values()) | ||
| config_values = json.loads(json.dumps(config_values, cls=NumpyEncoder)) |
There was a problem hiding this comment.
can we directly call
config_dict=json.loads(json.dumps(config, cls=NumpyEncoder))
config=Configuration(configuration_space=config.config_space, values=config_dict))
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1241 plus some flake fixes
Actual Results
Config selector cannot find new configurations.
Reason
Configs are added to the runhistory twice because the runhistory sees the configs with different types but same values as distinct.
Fix
Convert all config values to built-in python types via json serialization.