This repository was archived by the owner on Oct 16, 2019. It is now read-only.
Improve JSON serialization compatibility of User #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/unit/membership_cache_spec.rb
Outdated
| @@ -1,19 +1,18 @@ | |||
| require 'spec_helper' | |||
| require 'byebug' | |||
There was a problem hiding this comment.
Should we add byebug to the gemspec's development dependencies?
There was a problem hiding this comment.
Oops, that's a left over. I'm fine with adding it when I need it. I'll remove this one.
|
Hi @fphilipe! Have you tested this in a production application? I can cut a release if this fixes stuff for you. |
|
Hey @atmos. Yeah, I'm using this in production right now. My latest version of warden-github-rails doesn't play well with warden-github in combination with rails' json cookie serializer (marshal works just fine). I'd appreciate a new cut 😉 |
Previously, the MembershipCache was a subclass of Hash. When serializing to and deserializing from JSON, the MembershipCache would become a Hash and blow up. This is a problem in warden-github-rails where I switched to a custom warden (de)serialization in order to properly support JSON serialization and also to support mocked users in test environments between requests[1]. [1]: fphilipe/warden-github-rails@db82470
fphilipe
force-pushed
the
improve-json-serialization-compatibility
branch
from
a0e6921 to
c617777
Compare
|
1.3.0 is up on rubygems. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
MembershipCachewas a subclass ofHash. When serializing to and deserializing from JSON, theMembershipCachewould become aHashand blow up. This is a problem in warden-github-rails where I switched to a custom warden (de)serialization in order to properly support JSON serialization and also to support mocked users in test environments between requests (relevant warden-github-rails commit).