Skip to content

remote: replace async void Disconnect with Task-returning method #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2025
Merged

remote: replace async void Disconnect with Task-returning method #2179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Proto.Remote/Endpoints/EndpointReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ ServerCallContext context

var cancellationTokenSource = new CancellationTokenSource();

async void Disconnect()
async Task DisconnectAsync()
{
try
{
Expand All @@ -65,13 +65,13 @@ async void Disconnect()
finally
{
// When we disconnect, cancel the token, so the reader and writer both stop, and this method returns,
// so that the stream actually closes. Without this, when kestrel begins shutdown, it's possible the
// so that the stream actually closes. Without this, when kestrel begins shutdown, it's possible the
// connection will stay open until the kestrel shutdown timeout is reached.
cancellationTokenSource.Cancel();
}
}

await using (_endpointManager.CancellationToken.Register(Disconnect).ConfigureAwait(false))
await using (_endpointManager.CancellationToken.Register(() => DisconnectAsync()).ConfigureAwait(false))
{
IEndpoint endpoint;
string? address = null;
Expand Down
Loading