Skip to content

refactor: replace sleep with async wait in supervision test #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2025
Merged

refactor: replace sleep with async wait in supervision test #2172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/Proto.Actor.Tests/SupervisionTests_OneForOne.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,13 @@ public async Task OneForOneStrategy_Should_RestartParentOnEscalateFailure()
context.Spawn(grandParentProps);

parentMailboxStats.Reset.Wait(1000);
Thread.Sleep(1000); //parentMailboxStats.Received could still be modified without a wait here
Assert.Contains(parentMailboxStats.Received, msg => msg is Restart);
var deadline = DateTime.UtcNow + TimeSpan.FromSeconds(1);
while (!parentMailboxStats.Received.ToArray().Any(msg => msg is Restart) && DateTime.UtcNow < deadline)
{
await Task.Delay(10);
}

Assert.Contains(parentMailboxStats.Received.ToArray(), msg => msg is Restart);
}

private class ParentActor : IActor
Expand Down
Loading