Ensure that WithSenderMiddleware actually chains middleware calls
#1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also removed `WithInnerContext` since it seems a little silly to have to allocate another decorator object when `WithSenderMiddleware` could just set the inner context. I'm happy to change this back if you feel it's necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also removed
WithInnerContextsince it seems a little silly to have to allocate another decorator object whenWithSenderMiddlewarecould just set the inner context. I'm happy to revert that bit if you feel it's necessary.Description
Purpose
This pull request is a:
Checklist