Changed K8s provider to use annotations instead of labels for kind propagation #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…caused by K8s provider constraints
This allows for up to 63 characters for kind name
…e cluster kinds. This removes the restrictions on the kind names to match K8s label rules.
# Conflicts: # benchmarks/KubernetesDiagnostics/KubernetesDiagnostics.csproj # benchmarks/KubernetesDiagnostics/Program.cs # src/Proto.Cluster.CodeGen/CodeGenerator.cs # src/Proto.Cluster.Kubernetes/KubernetesProvider.cs
marcinbudny
reviewed
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1752, removes limitations around cluster kind naming.
Breaking changes