Skip to content

Conversation

@elnur-m
Copy link
Contributor

@elnur-m elnur-m commented Aug 9, 2022

Description

I've prefixed code-generated actor's Kind property with the .proto file's package name. The purpose behind this is to be able to create grains with the same name in different C# namespaces. One example would be creating an Account grain in App.Security namespace and another Account grain in App.Finance namespace.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Elnur Mammadov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mhelleborg mhelleborg merged commit cab4ac6 into asynkron:dev Aug 9, 2022
@rogeralsing
Copy link
Contributor

IMO we should use protobuf package name rather than .net namespace for this for future compatibility with Go cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants