Skip to content

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 1, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Running task general:cache-dep-licenses will automatically update the deb package license recap in one go.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change renders this workflow step obsolete:

- name: Check debian copyright file
run: |
task update-deb-copyright
git diff --color --exit-code

(since an out of sync copyright file will now be caught by the "Check for outdated cache" step in the workflow)

So the unnecessary step should be removed from the workflow to avoid unnecessary clutter and maintenance burden.


debian/arduino-cli/usr/share/doc/arduino-cli/copyright should be added to the paths filters of the "Check Go Dependencies" workflow:

push:
paths:
- ".github/workflows/check-go-dependencies-task.ya?ml"
- ".licenses/**"
- ".licensed.json"
- ".licensed.ya?ml"
- "Taskfile.ya?ml"
- "**/.gitmodules"
- "**/go.mod"
- "**/go.sum"
pull_request:
paths:
- ".github/workflows/check-go-dependencies-task.ya?ml"
- ".licenses/**"
- ".licensed.json"
- ".licensed.ya?ml"
- "Taskfile.ya?ml"
- "**/.gitmodules"
- "**/go.mod"
- "**/go.sum"

@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Sep 1, 2025
@cmaglie cmaglie self-assigned this Nov 14, 2025
@cmaglie
Copy link
Member Author

cmaglie commented Nov 14, 2025

Thanks @per1234 I've applied the suggestions.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.33%. Comparing base (08ff7e2) to head (bfdca11).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2991      +/-   ##
==========================================
+ Coverage   68.35%   69.33%   +0.97%     
==========================================
  Files         241      241              
  Lines       22724    18590    -4134     
==========================================
- Hits        15534    12889    -2645     
+ Misses       5992     4504    -1488     
+ Partials     1198     1197       -1     
Flag Coverage Δ
unit 69.33% <ø> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants