Use JSON for vars instead of query params #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resource used a chain of query params that looked like
`vars.key="value"`, that were originally sourced from JSON.
We can also pass vars in as `?vars={"key":"value"}` with JSON directly.
This means, we easily allow nested JSON, arrays or any other type we
are currently not handling by just passing the JSON string from the
Concourse itself and feeding it back into the URL.
arbourd
force-pushed
the
use-json-for-vars
branch
from
86053fd to
89ed070
Compare
smoke
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resource used a chain of query params that looked like
vars.key="value", that were originally sourced from JSON. We can also pass vars in as?vars={"key":"value"}with a JSON string directly, without having to parse the JSON and then reconstruct.This means, we easily allow nested JSON, arrays or any other type we are currently not handling by just passing the JSON string from the Concourse itself and feeding it back into the URL.
Closes #105