Skip to content

Feat heading component #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2022
Merged

Feat heading component #78

merged 3 commits into from
Oct 18, 2022

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Oct 13, 2022 •
edited
Loading

What does this PR do?

Replace elements like:

<h1 class="heading-level-4">Text</h1>

with:

<Heading tag="h1" size={4}>Text</Heading

we still have some headings which didn't have the heading-level-* class:

Screen Shot 2022-10-13 at 1 49 01 PM

Test Plan

Manual

Related PRs and Issues

None

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Oct 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
console ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 4:48PM (UTC)

stnguyen90
stnguyen90 commented Oct 13, 2022
View reviewed changes
TorstenDittmann
TorstenDittmann reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the implementation, it might be easier for us if the size is a string - so we don't have to use the curly braces. What do you think?

Even if it sounds silly, but that component is really easy to write tests for - so we might add some as well 👍🏻

@stnguyen90 stnguyen90 force-pushed the feat-heading-component branch from 3e1dda8 to 4dbd0b3 Compare October 17, 2022 16:46
@TorstenDittmann TorstenDittmann merged commit 3ec7fd4 into main Oct 18, 2022
@TorstenDittmann TorstenDittmann deleted the feat-heading-component branch October 18, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stnguyen90 @TorstenDittmann