Skip to content

Conversation

TorstenDittmann
Copy link
Contributor

@TorstenDittmann TorstenDittmann commented Oct 11, 2022

What does this PR do?

  • reusable store for persistent navigation

Test Plan

  • add unit tests for the store

Have you read the Contributing Guidelines on issues?

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
console ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 0:42AM (UTC)

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 inconsistency i found:

  1. navigate to Authentication > Users
  2. go to page 2
  3. click on Users tab heading

expected:

current page and URL matches

actual:

current page still indicates page 2, but the URL doesn't show page 2

Copy link
Contributor

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's possible to navigate to pages over the maximum limit (e.g. we can go to page 25 even if we have only 3 pages). Although it's a very niche case we might want to address it in some way :)

@TorstenDittmann TorstenDittmann changed the title draft: persistent pagination feat: persistent pagination Oct 12, 2022
@TorstenDittmann TorstenDittmann merged commit e3aed62 into main Oct 13, 2022
@TorstenDittmann TorstenDittmann deleted the feat-persisten-pagination branch October 13, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants