-
Notifications
You must be signed in to change notification settings - Fork 190
feat: persistent pagination #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 inconsistency i found:
- navigate to Authentication > Users
- go to page 2
- click on Users tab heading
expected:
current page and URL matches
actual:
current page still indicates page 2, but the URL doesn't show page 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's possible to navigate to pages over the maximum limit (e.g. we can go to page 25 even if we have only 3 pages). Although it's a very niche case we might want to address it in some way :)
What does this PR do?
Test Plan
Have you read the Contributing Guidelines on issues?
✅