Feature new metrics #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurWrong
commented
Mar 9, 2023
ArthurWrong
commented
- According to FLIP-33, I replace tpsMetric and outTps with numRecordsInPerSecond and numRecordsOutPerSecond, and replace their counter with numRecordsIn and numRecordsOut at the same time.
- Additionally, numRecordsIn, numRecordsOut, numRecordsInPerSecond, numRecordsOutPerSecond, these four metrics can be monitored on aliyun vvp.
humkum
reviewed
Mar 22, 2024
src/main/java/org/apache/rocketmq/flink/legacy/common/util/MetricUtils.java
Outdated
Show resolved
Hide resolved
|
Thanks for your contributions! Can you rebase to last main branch. |
ArthurWrong
force-pushed
the
feature_new_metrics
branch
3 times, most recently
from
7f0a13a to
d2278cf
Compare
ArthurWrong
force-pushed
the
feature_new_metrics
branch
from
d2278cf to
12d8922
Compare
Done. |
|
@lizhimins @humkum Can we review the code and merge it into the main branch？ |
lizhimins
approved these changes
May 17, 2024
tchivs
added a commit
to tchivs/rocketmq-flink
that referenced
this pull request
Jul 8, 2024
According to FLIP-33, I replace tpsMetric and outTps with numRecordsInPerSecond and numRecordsOutPerSecond, and replace their counter with numRecordsIn and numRecordsOut at the same time. Additionally, numRecordsIn, numRecordsOut, numRecordsInPerSecond, numRecordsOutPerSecond, these four metrics can be monitored on aliyun vvp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.