- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.5k
 
Bump to Java 11 #3314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bump to Java 11 #3314
Conversation
| 
           Removing JDK21 because Spotless is not compatible yet, and we can't update because of dropped JDK8 support. Also, Hadoop 3.3.0 does not support JDK21.  | 
    
        
          
                pom.xml
              
                Outdated
          
        
      | <maven.compiler.source>11</maven.compiler.source> | ||
| <maven.compiler.target>11</maven.compiler.target> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should start using maven.compiler.release instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, updated 👍
| 
           What's the status of this PR? It's blocking #3182 which is necessary to use recent protobuf versions. I'm trying to prepare a PR to upgrade   | 
    
Rationale for this change
See dev-list: https://lists.apache.org/thread/cblz22jgllyvw2t63xs3fbzxcvhy5y42
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?