- 
                Notifications
    
You must be signed in to change notification settings  - Fork 652
 
feat(object_store): Implement copy_if_not_exists, put_multipart_opts and metadata in GetResult #6468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(object_store): Implement copy_if_not_exists, put_multipart_opts and metadata in GetResult #6468
Conversation
381093b    to
    e899c2e      
    Compare
  
    | 
           FYR, @Xuanwo refer to burnett01/[email protected] is not allowed to be used in apache/opendal.  | 
    
| 
           Hi, please change into Burnett01/rsync-deployments@0dc935c instead. All approved actions are listed here: https://github.com/apache/infrastructure-actions/blob/f65b1b9f5c4a50a7559fed2773a00f6361e1fe56/approved_patterns.yml#L55  | 
    
91bfd45    to
    89bf93b      
    Compare
  
    | 
           Thanks, I fix it in the latest update.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM, thank you for working on this!
Signed-off-by: codephage. <[email protected]>
Signed-off-by: codephage. <[email protected]>
Signed-off-by: codephage. <[email protected]>
Signed-off-by: codephage. <[email protected]>
Signed-off-by: codephage. <[email protected]>
Signed-off-by: codephage. <[email protected]>
4e4de35    to
    8925cb4      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
| options.content_encoding = Some(value.to_string()); | ||
| } | ||
| object_store::Attribute::ContentLanguage => { | ||
| // no support | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create an issue for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tracing in #6470
Which issue does this PR close?
Closes #6467 .
Rationale for this change
What changes are included in this PR?
Summary by copilot
Are there any user-facing changes?