Skip to content

Conversation

@codephage2020
Copy link
Contributor

Which issue does this PR close?

Closes #6467 .

Rationale for this change

What changes are included in this PR?

Summary by copilot

  • Implemented put_multipart_opts to support setting object attributes during multipart upload.
  • Added copy_if_not_exists with error handling for already existing files.
  • Populated GetResult.attributes with user-defined object metadata.

Are there any user-facing changes?

@codephage2020 codephage2020 requested a review from Xuanwo as a code owner August 1, 2025 02:52
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Aug 1, 2025
@codephage2020 codephage2020 force-pushed the feat(object_store)/Medium-Priority-tasks-of-#6446 branch from 381093b to e899c2e Compare August 1, 2025 02:54
@codephage2020
Copy link
Contributor Author

FYR, @Xuanwo
It seems to be a problem with CI.

refer to burnett01/[email protected] is not allowed to be used in apache/opendal.

@Xuanwo
Copy link
Member

Xuanwo commented Aug 1, 2025

Hi, please change into Burnett01/rsync-deployments@0dc935c instead.

All approved actions are listed here: https://github.com/apache/infrastructure-actions/blob/f65b1b9f5c4a50a7559fed2773a00f6361e1fe56/approved_patterns.yml#L55

@codephage2020 codephage2020 force-pushed the feat(object_store)/Medium-Priority-tasks-of-#6446 branch from 91bfd45 to 89bf93b Compare August 1, 2025 14:58
@codephage2020
Copy link
Contributor Author

Thanks, I fix it in the latest update.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thank you for working on this!

@codephage2020 codephage2020 force-pushed the feat(object_store)/Medium-Priority-tasks-of-#6446 branch from 4e4de35 to 8925cb4 Compare August 2, 2025 04:39
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

options.content_encoding = Some(value.to_string());
}
object_store::Attribute::ContentLanguage => {
// no support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tracing in #6470

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 2, 2025
@Xuanwo Xuanwo merged commit e68fbfc into apache:main Aug 2, 2025
35 checks passed
@codephage2020 codephage2020 deleted the feat(object_store)/Medium-Priority-tasks-of-#6446 branch August 2, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete Medium Priority parts of #6446

2 participants