examples/elf: Fix invalid preprocessor directive syntax #3193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix invalid preprocessor directive in elf_main.c by changing `# Warning "No file system selected"` to `# warning "No file system selected"`. The incorrect uppercase "Warning" directive would cause compilation errors, while the proper lowercase "warning" directive generates the intended compiler warning when no file system is selected. Signed-off-by: Huang Qi <[email protected]>
xiaoxiang781216
approved these changes
Oct 18, 2025
linguini1
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Why change is necessary: This change fixes a critical compilation error in the ELF example. The invalid preprocessor directive # Warning would cause the build to fail when no file system is selected in the configuration, preventing users from building the
ELF example.
• What functional part of the code is being changed: The examples/elf/elf_main.c file, specifically the preprocessor directive section that handles the case when no file system is configured.
• How does the change exactly work: The change corrects the preprocessor directive syntax from # Warning "No file system selected" to # warning "No file system selected". The lowercase "warning" is the proper C preprocessor directive that generates a
compiler warning, while the uppercase "Warning" is invalid syntax that causes compilation errors.
• Related NuttX Issue reference: None specific - this is a bug fix discovered during code review.
• Related NuttX Apps Issue/Pull Request reference: None specific - this is a standalone fix.
Impact
• Is new feature added? Is existing feature changed?: NO - This is purely a bug fix that restores the intended functionality without changing any features.
• Impact on user: NO - Users will not need to adapt to any changes. In fact, this fix improves user experience by allowing the ELF example to compile successfully when no file system is configured.
• Impact on build: NO - The build process remains the same, but this fix prevents build failures in specific configurations.
• Impact on hardware: NO - This change is purely in the application layer and does not affect any hardware, architecture, or driver code.
• Impact on documentation: NO - No documentation changes are required as this is a straightforward syntax correction.
• Impact on security: NO - This change has no security implications.
• Impact on compatibility: NO - This fix maintains backward compatibility and does not affect interoperability.
• Anything else to consider: This fix ensures that the ELF example can be built in configurations where no file system is selected, which is important for testing and minimal configurations.
Testing
I confirm that changes are verified on local setup and works as intended:
Testing logs before change:
$ make examples/elf
CC: examples/elf/elf_main.c
examples/elf/elf_main.c:316:3: error: invalid preprocessing directive #Warning
316 | # Warning "No file system selected"
| ^~~~~~~
Testing logs after change:
$ make examples/elf
CC: examples/elf/elf_main.c
examples/elf/elf_main.c:316:3: warning: #warning "No file system selected"
316 | # warning "No file system selected"
| ^~~~~~~