Skip to content

Clean up JavadocUtilTest #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2025
Merged

Clean up JavadocUtilTest #1210

merged 3 commits into from
Jul 1, 2025

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jun 26, 2025 •
edited
Loading

  1. Replace always passing assert with actual assert
  2. Typos
  3. Unthrown exceptions
  4. expected argument comes before actual in assert
  5. Use Java 1.7 method for line separator

@elharo elharo changed the title Replace always pasing assert with actual assert Clean up JavadocUtilTest Jun 27, 2025
@elharo elharo marked this pull request as ready for review July 1, 2025 11:31
@elharo elharo requested a review from michael-o July 1, 2025 11:31
@elharo elharo merged commit 70a9fe9 into master Jul 1, 2025
206 of 231 checks passed
@elharo elharo deleted the true branch July 1, 2025 13:59
@github-actions github-actions bot added this to the 3.11.3 milestone Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

@elharo elharo

Labels
maintenance
Projects
None yet
Milestone
3.11.3
Development

Successfully merging this pull request may close these issues.
3 participants
@elharo @michael-o @olamy