[MJAVADOC-783] Invalid path when using TagletArtifact and TagletPath

[jira-importer]

Rob Gordon opened MJAVADOC-783 and commented

I’m trying to use the Javadoc plugin with both a tagletartifact and a tagletpath but I get an InvliadPathException from the Javadoc goal.

I can see from the generated options file that there is no separator between the end of the artifact path and the taglet path.

I think the problem is that getTagletPath method of AbstractJavadocMojo should check for an existing path before adding the tagletpath. Something like:

        if (tagletpath != null && !tagletpath.isEmpty()) {
            if (path.length() > 0) {
                 path.append(File.pathSeparator);
           }

            path.append(JavadocUtil.unifyPathSeparator(tagletpath));
        }

I looked at creating a pull request but I can’t work out how to create a suitable test. I found a taglet-test-plugin-config.xml, but not where it’s used.

Could someone familiar with this codebase possibly take a look at this problem please?

My configuration can be seen here: https://github.com/robjg/oj-parent/blob/d3e2328ca285516f1a4f6ee2bce94b44ba89b748/pom.xml#L304

I attempted to report this problem via 'users@maven.apache.org' however my mail did not make it. 

---

Affects: 3.6.3

Issue Links:

• MJAVADOC-775 Option 'taglets/taglet/tagletpath' ignored when pointing to a JAR
  ("is duplicated by")

Remote Links:

• GitHub Pull Request #255
  
• GitHub Pull Request #300
  

0 votes, 5 watchers

[jira-importer]

Michael Osipov commented

Can you provide a sample project which cases the exception?

[jira-importer]

Alexander Kriegisch commented

I attempted to report this problem via 'users@maven.apache.org' however my mail did not make it.

Even after a quarter of the 21st century has passed, Apache mailing lists stubbornly insist on only accepting plain text messages. I am sure, that saves the Internet bandwidth-wise and the planet as a whole, and everyone still reads e-mails on text consoles. I actually also like to write plain text messages, even in business. But sometimes, it makes sense to have some formatting for inline code blocks and them not being butchered by word wrap, or to insert some explanatory inline pics, making the message so much easier and quicker to read than attaching same pics and code blocks as extra files which the reader then has to open one by one, trying to fully understand the message.

An organisation at the forefront of OSS development, fostering an innovative spirit, should think about whether it makes sense to hang on to anachronisms like that at the danger of becoming an anachronism itself one day.

Sorry to all sensitive souls for the snarky comment, but I could not resist and am gladly taking all your blame.

[jira-importer]

Elliotte Rusty Harold commented

Call me a luddite, but developers work in plain text for good reason, and that should include email. We'd all be better off if HTML email had never been invented.

[jira-importer]

Michael Osipov commented

I fully agree with Elliotte Rusty Harold, HTML is the worst ever happened to email. We all know who's fault is this.

[jira-importer]

Alexander Kriegisch commented

Elliotte Rusty Harold, no I won't call you a luddite.

Elliotte Rusty Harold and Michael Osipov, I do not wish to start a general debate about the pros and cons of HTML mail here, so please forgive me for my digression above. Anyway, I cannot help but notice that, while the two of you agree, I gave reasons for my statement, but the two of you simply stated something as if it was a fact, which it is not. It is just an opinion, and both of you expressed your respective opinions as what in German we call "killer phrases".

"Even when the experts all agree, they may well be mistaken." -- Bertrand Russell

[jira-importer]

Alexander Kriegisch commented

Fixed by #255. I gave robjg proper credit as a co-author of the commit fixing the same problem as his suggestion, just in a syntactically slightly different way.

[jira-importer]

Rob Gordon commented

Thanks Alexander, I built the plugin from your clone - it works fine. Many thanks for fixing this.

[jira-importer]

Michael Osipov commented

Fixed with be2fa208674c781b08658878ae375f2c058992fc.