[MCHECKSTYLE-439] Upgrade to parent 40 #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get rid of warnings. Also, downgrade plexus plugin from 2.1.1 to 2.1.0 as 2.1.1 is known to be broken. --- https://issues.apache.org/jira/browse/MCHECKSTYLE-439
Member
|
whats wrong with plexus? |
Member
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
version for maven-invoker-plugin can be removed in line 360
Member
Author
|
Plexus 2.1.1 uses broken qdox, fixed here codehaus-plexus/plexus-containers@88f833b but never released (nor we want it released, as we should move off plexus not keep it updated) |
Member
|
I can do a release anyway of the plexus container. We also made more cleanups |
slawekjaranowski
approved these changes
Jun 30, 2023
Member
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
We can remove plexus annotation in next step
Member
|
@cstamas Do you want to complete this? |
Member
Author
Go for it, am more on other topics currently |
|
Resolve #350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get rid of warnings.
Also, downgrade plexus plugin from 2.1.1 to 2.1.0 as 2.1.1 is known to be broken.
https://issues.apache.org/jira/browse/MCHECKSTYLE-439