Skip to content

Conversation

@regend
Copy link
Contributor

@regend regend commented Sep 29, 2025

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
This PR fixes a hardcoded page value in the GitLab remote API pagination logic. The code was previously hardcoded to start pagination from page 1, which could cause issues with proper pagination handling when users specify different starting pages or when resuming from a specific page.

Does this close any open issues?

Closes xx

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug labels Sep 29, 2025
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for your contribution.

@klesh klesh merged commit ae3edc9 into apache:main Sep 29, 2025
14 checks passed
@regend regend deleted the fix/gitlab-project-page branch September 29, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/plugins This issue or PR relates to plugins needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants