fix(github_graphql): add missing runId for graphql jobs #8420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a regression in the GitHub GraphQL API job collection introduced by issues #8383 and #8233. The regression caused the
runIDof the GraphQL extracted job to incorrectly reference the job ID instead of the workflow run ID, leading to empty DORA metrics.Changes
Introduced a new DAL struct to correctly store the
RunIDfor GitHub GraphQL collected jobs.Does this close any open issues?
Closes #8415
Screenshots
{ "RunId": 14767773733, "Id": "******", "Name": "*******", "DetailsUrl": "https://github.com/*****/*****/actions/runs/14767773733/job/41462433961", "DatabaseId": 41462433961, "Status": "COMPLETED", "StartedAt": "2025-05-01T01:29:58Z", "Conclusion": "SUCCESS", "CompletedAt": "2025-05-01T01:36:13Z", "Steps": { "TotalCount": 1, "Nodes": [ { "completed_at": "2025-05-01T01:30:00Z", "conclusion": "SUCCESS", "name": "****", "number": 1, "seconds_to_completion": 2, "started_at": "2025-05-01T01:29:58Z", "status": "COMPLETED" } ] } }