Skip to content

Cherry-pick to release-v1.0 -- fix(circleci): CircleCI Workflow nil check for CreatedDate (#8310) #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 7, 2025
Merged

Cherry-pick to release-v1.0 -- fix(circleci): CircleCI Workflow nil check for CreatedDate (#8310) #8314

merged 4 commits into from
Mar 7, 2025

Conversation

@magichair
Copy link
Contributor

Cherry pick of #8310

@magichair @jibsen-vh
fix(circleci): CircleCI Workflow nil check for CreatedDate (apache#8310)
de29e4a 
* fix(circleci): Add CircleCI workflow nil check for CreatedDate

Adds a nil check during `convertWorkflows` task when CircleCI workflows API returns a weird malformed pipeline data with no created_date. Previously, the entire task fails and panics when trying to get convert a nil in ToTime util.

Fixes Issue apache#8309

* Update to fix compile problems

* Tweak the _tool csv to allow for the NULL value entries

---------

Co-authored-by: John Ibsen <[email protected]>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. component/plugins This issue or PR relates to plugins labels Feb 28, 2025
@magichair magichair mentioned this pull request Feb 28, 2025
Merged
4 tasks
@magichair
Copy link
Contributor Author

Ah looks like it maybe didn't get all the commits from the cherry-pick, didn't realize it wasn't squash and merged. I'll fix that today. 🙇

@klesh klesh changed the base branch from release-v1.0 to main March 6, 2025 08:05
@klesh
Copy link
Contributor

klesh commented Mar 6, 2025

Thanks for the PR.
Can you check the tests when you find time? Thanks.
FYI: We just made the main branch pointing to the stable branch (previously release-v1.0), so I changed the base of this PR.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 7, 2025
@jibsen-vh
Copy link
Contributor

jibsen-vh commented Mar 7, 2025 •
edited
Loading

@klesh should be better. I was working from a diverged point in the circleci plugin, fixed it up for cherry picking to latest releases. Sorry for the delay on this.
See 430483f

@klesh klesh merged commit 24ca478 into apache:main Mar 7, 2025
10 of 11 checks passed
@klesh
Copy link
Contributor

klesh commented Mar 7, 2025

@jibsen-vh You are right. The fix looks solid to me. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klesh klesh klesh approved these changes

Assignees

No one assigned

Labels

component/plugins This issue or PR relates to plugins size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@magichair @klesh @jibsen-vh