-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[feat] Add webhook authentication support for alert notifications #3797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add Basic Auth and Bearer Token authentication types to webhook notifications - Update NoticeReceiver entity with hookAuthType and hookAuthToken fields - Implement authentication headers in WebHookAlertNotifyHandlerImpl - Add frontend UI support for webhook authentication configuration - Update i18n translations for new authentication options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I have a suggestion to discuss with you, This implementation maybe too specific. how about allowing users to set arbitrary http headers, which can cover more authorizations like Basic/Bearer or company-specific authorization headers.
Yeah, I consider about it, but there are some problems we need to solve first: If we allow users to pass the whole headers, it may passed it as a HashMap, there is not have a good way to render it in the frontend. I prefer a simple feature for now, to keep the authentication part simple (user may enter a whole json string or add key-value table like the notifier rules, there is more complexity). And because I'm new to this project, So I wanna to push a simple feature first, then we can discuss more about the headers part. What do you think? If you can help to implement it, that would be great. |
Hi, about UI design of HTTP headers, you can either refer to the designs of other systems or implement it according to your own ideas. If any issues, we could discuss together. |
|
Hi👍, suggest the common HTTP headers +1. |
|
@Jetiaime hi, pls fix ci |
What's changed?
Add Authentication Header On WebHooks
Checklist
Add or update API