HDFS-11115 Remove bytes2String and string2Bytes #152
+1,354
−1,417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use String.getBytes(StandardCharsets.UTF_8) instead of String.getBytes(String).
Uppercased `newline' since it's a constant, and made line lengths no more than 80 chars.
Since StandardCharsets makes converting between (utf-8) bytes and strings
trivial, let's remove the methods:
- org.apache.hadoop.hdfs.DFSUtilClient.bytes2String
- org.apache.hadoop.hdfs.DFSUtilClient.string2Bytes
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
1. The ClientHelper now checks inactive application IDs so it can get status for terminated jobs in addition to running jobs 2. JobRunner.kill() waits for any finish, not just successful finish. 3. A killed job is now considered successful. Author: Jacob Maes <[email protected]> Reviewers: Prateek Maheshwari <[email protected]> Closes apache#152 from jmakes/samza-1250
This was referenced Jul 1, 2025
Merged
This was referenced Jul 18, 2025
This was referenced Jul 28, 2025
This was referenced Aug 4, 2025
This was referenced Aug 25, 2025
This was referenced Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since StandardCharsets makes converting between (utf-8) bytes and strings
trivial, let's remove the methods:
- org.apache.hadoop.hdfs.DFSUtilClient.bytes2String
- org.apache.hadoop.hdfs.DFSUtilClient.string2Bytes