Skip to content

[common] Support general DELETE statement on primary key table. #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[common] Support general DELETE statement on primary key table. #1597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/sink/FlinkTableSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

package org.apache.fluss.flink.sink;

import org.apache.flink.table.types.DataType;
import org.apache.flink.table.types.utils.DataTypeUtils;
import org.apache.fluss.config.Configuration;
import org.apache.fluss.flink.sink.serializer.RowDataSerializationSchema;
import org.apache.fluss.flink.sink.writer.FlinkSinkWriter;
Expand Down Expand Up @@ -307,8 +309,28 @@ public Optional<Long> executeDeletion() {
@Override
public RowLevelDeleteInfo applyRowLevelDelete(
@Nullable RowLevelModificationScanContext rowLevelModificationScanContext) {
throw new UnsupportedOperationException(
"Currently, Fluss table only supports DELETE statement with conditions on primary key.");
validateUpdatableAndDeletable();
Map<String, DataType> primaryKeyDataTypes = getPrimaryKeyDataTypes();
if (primaryKeyDataTypes.isEmpty()) {
throw new UnsupportedOperationException(
String.format(
"Table %s is a Log Table. Log Table doesn't support DELETE statements.",
tablePath));
}
return new RowLevelDeleteInfo() {
@Override
public Optional<List<Column>> requiredColumns() {
return Optional.of(primaryKeyDataTypes.entrySet()
.stream()
.map(pkDateType -> Column.physical(pkDateType.getKey(), pkDateType.getValue()))
.collect(Collectors.toList()));
}

@Override
public RowLevelDeleteMode getRowLevelDeleteMode() {
return RowLevelDeleteMode.DELETED_ROWS;
}
};
}

@Override
Expand Down Expand Up @@ -362,6 +384,14 @@ private void validateUpdatableAndDeletable() {
}
}

private Map<String, DataType> getPrimaryKeyDataTypes() {
Map<String, DataType> pkDataTypes = new HashMap<>();
for (int index : primaryKeyIndexes) {
pkDataTypes.put(tableRowType.getFieldNames().get(index), DataTypeUtils.toInternalDataType(tableRowType.getTypeAt(index)));
}
return pkDataTypes;
}

private Map<Integer, LogicalType> getPrimaryKeyTypes() {
Map<Integer, LogicalType> pkTypes = new HashMap<>();
for (int index : primaryKeyIndexes) {
Expand Down
Loading