-
Notifications
You must be signed in to change notification settings - Fork 379
Union read support log table in streaming mode #1575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caozhen1937 Thanks for the pr. Left minor comments. PTAL
@@ -37,6 +37,6 @@ public Map<Integer, Long> getBucketOffsets( | |||
@Nullable String partitionName, | |||
Collection<Integer> buckets, | |||
OffsetsInitializer.BucketOffsetsRetriever bucketOffsetsRetriever) { | |||
return Collections.emptyMap(); | |||
return buckets.stream().collect(Collectors.toMap(x -> x, x -> Long.MAX_VALUE)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this?
...nk-common/src/main/java/com/alibaba/fluss/flink/source/enumerator/FlinkSourceEnumerator.java
Outdated
Show resolved
Hide resolved
...e-paimon/src/test/java/com/alibaba/fluss/lake/paimon/flink/FlinkUnionReadLogTableITCase.java
Outdated
Show resolved
Hide resolved
...s-lake-paimon/src/test/java/com/alibaba/fluss/lake/paimon/utils/FlinkRowAssertionsUtils.java
Outdated
Show resolved
Hide resolved
c5f0293
to
f350dfd
Compare
bb44bf3
to
2e2ff1a
Compare
@caozhen1937 Hi, I append a commit to improve the enumerator logic. PTAL |
a6f3e48
to
8710286
Compare
@luoyuxia LGTM. Thank you for your guidance. |
Purpose
Linked issue: close #1436
Brief change log
Tests
API and Format
Documentation