Skip to content

Conversation

caozhen1937
Copy link
Contributor

Purpose

Linked issue: close #1436

Brief change log

Tests

API and Format

Documentation

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caozhen1937 Thanks for the pr. Left minor comments. PTAL

@@ -37,6 +37,6 @@ public Map<Integer, Long> getBucketOffsets(
@Nullable String partitionName,
Collection<Integer> buckets,
OffsetsInitializer.BucketOffsetsRetriever bucketOffsetsRetriever) {
return Collections.emptyMap();
return buckets.stream().collect(Collectors.toMap(x -> x, x -> Long.MAX_VALUE));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

@caozhen1937 caozhen1937 marked this pull request as ready for review August 24, 2025 06:29
@luoyuxia
Copy link
Contributor

@caozhen1937 Hi, I append a commit to improve the enumerator logic. PTAL

@luoyuxia luoyuxia force-pushed the FLUSS_ISSUE_1436_v2 branch from a6f3e48 to 8710286 Compare August 26, 2025 11:55
@caozhen1937
Copy link
Contributor Author

@luoyuxia LGTM. Thank you for your guidance.

@luoyuxia luoyuxia merged commit 7937996 into apache:main Aug 27, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Union read support log table in streaming mode
2 participants