optimizer: Rewrite IS NOT DISTINCT FROM
joins as Hash Joins
#17319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The following join query now it's using NLJ. Given the equal join operators like Hash Join, SortMergeJoin supports a special null comparison behavior:
NULL=NULL
->true
instead of the defaultNULL
, this query can be safely re-written to equal join with equi-join operator'snull_equals_null
option enabled.Given HJ is faster than NLJ in general, this optimization can make similar queries more efficient.
I've verified that DuckDB is already doing so
What changes are included in this PR?
Modified logical optimizer pass
ExtractEquijoinPredicate
to also handleIS NOT DISTINCT FROM
case.INDF expressions will only be extracted to equal join condition, if the join predicate has 0 equality expr, and several INDF comparisons. See the implementation for more details.
Are these changes tested?
sqllogictests (mostly check the plans include HashJoin if the conversion is possible)
Are there any user-facing changes?
No