Skip to content

fix: Ensure the CachedParquetFileReader respects the metadata prefetch hint #17302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Ensure the CachedParquetFileReader respects the metadata prefetch hint #17302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions datafusion/datasource-parquet/src/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ impl ParquetFileReaderFactory for CachedParquetFileReaderFactory {
file_metrics,
file_meta,
metadata_cache: Arc::clone(&self.metadata_cache),
metadata_size_hint,
}))
}
}
Expand All @@ -222,6 +223,7 @@ pub struct CachedParquetFileReader {
pub inner: ParquetObjectReader,
file_meta: FileMeta,
metadata_cache: Arc<dyn FileMetadataCache>,
metadata_size_hint: Option<usize>,
}

impl AsyncFileReader for CachedParquetFileReader {
Expand Down Expand Up @@ -261,11 +263,10 @@ impl AsyncFileReader for CachedParquetFileReader {
#[cfg(not(feature = "parquet_encryption"))]
let file_decryption_properties = None;

// TODO there should be metadata prefetch hint here
// https://github.com/apache/datafusion/issues/17279
DFParquetMetadata::new(&self.store, &file_meta.object_meta)
.with_decryption_properties(file_decryption_properties)
.with_file_metadata_cache(Some(Arc::clone(&metadata_cache)))
.with_metadata_size_hint(self.metadata_size_hint)
.fetch_metadata()
.await
.map_err(|e| {
Expand Down