fix: parse error on unnamed arg with default syntax #2091
+51
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
DEFAULTvariant of theCREATE FUNCTIONdefault argument syntax causes a parse error with unnamed arguments. The proposed fix skips the logic to disambiguateargname argtypefromargtypewhen theDEFAULTkeyword is detected. IIUC, this is safe becauseargnameandargtypecan only take on the nameDEFAULTwhen quoted.e.g, in postgres this is allowed:
But "DEFAULT" (the argname) and "DEFAULT" (the argtype) cannot appear unquoted
Ref: apache/datafusion#18450 (comment)