Critical Issue: not working with external sdcard on phones like Samsung A7, A20, Note8, Huawei etc

[azizbohra]

Bug Report

Critical Issue. Need a solution. Please help me guys.

Problem

This plugin works perfectly with internal storage. But on some of the smartphones like Samsung A7 & one Huawei, it is not working with the external sdcard. Even after giving external storage path, it is always searching on internal storage.

What is expected to happen?

It should work with internal storage as well as external sdcard storage

What does actually happen?

Not working with external sdcard storage. Even after giving external storage path, it is always searching on internal storage.

Information

I have tested this plugin on Ionic1 project. Mount sdcard on your device. Check any file which exists on sdcard ($cordovaFile.checkFile), it will through error code 1 NOT_FOUND_ERR. Now copy same file on internal storage, it will work as expected. Because it is searching file only on internal storage not on external storage.

Command or Code

$cordovaFile.checkFile('file://sdcard/', "image.jpeg")
.then(function (success) {
// success
}, function (error) {
// error it will through error code 1 NOT_FOUND_ERR
});

Environment, Platform, Device

Ionic1
Samsung A7, Huawei

[breautek]

Are you able to provide a minimal sample reproduction app without ionic to reproduce this issue? $cordovaFile.checkFile is not something that comes from Cordova so this will help us rule out that this is an ionic specific issue or if this is indeed an issue in the Cordova framework.

https://github.com/apache/cordova-contribute/blob/master/create-reproduction.md

Thanks.

[azizbohra]

https://github.com/apache/cordova-contribute/blob/master/create-reproduction.md

@breautek Here is a link to repository having reproduction sample.
Please resolve this issue as soon as possible.
https://github.com/azizbohra/reproduction-sample.git

This is an issue with smartphones like Samsung A7, A20, Note8, Huawei etc
When you choose file from external sdcard and call resolveLocalFileSystemURL function, it will throw an error NOT_FOUND_ERROR with error code 1

I have used 3 cordova plugins to achieve this feature:

1. cordova-plugin-file 6.0.2 "File"
2. cordova-plugin-filechooser 1.2.0 "File Chooser"
3. cordova-plugin-filepath 1.5.6 "cordova-plugin-filepath"

Platform Info:
8.1.2 (cordova-lib@8.1.1)
android 7.1.4

This is my code:

var btnChooseFile = document.getElementById('chooseFile');

    btnChooseFile.addEventListener('click', function () {
        fileChooser.open(function (uri) { // this will give content://

            window.FilePath.resolveNativePath(uri, function (path) { // this will give file://

                window.resolveLocalFileSystemURL(path, function (fileEntry) {
                    alert('resolveLocalFileSystemURL success = ' + JSON.stringify(fileEntry));

                    fileEntry.file(function (file) {
                        var fileObj = {
                            path: fileEntry.nativeURL,
                            name: fileEntry.name,
                            mimeType: file.type,
                            size: file.size
                        };

                        alert('fileEntry success = ' + JSON.stringify(fileObj));
                    });
                }, function (error) {
                    alert('resolveLocalFileSystemURL error = ' + JSON.stringify(error));
                });
            }, function (error) {
                alert('resolveNativePath error = ' + JSON.stringify(error));
            });

        }, function (error) {
            alert(JSON.stringify(error));
        });
    });

[breautek]

Thanks, I think this will help. I won't be able to test today because I dont have a phone with an sd card slot. But I'll try to spend a few minutes to at least identify the fault in my workplace on monday where I have access to other phones.

One other note though, I read other tickets that have a similar issue as you, and it was due to a missing permission declaration. In the meantime, I'd advise you to check your AndroidManifest.xml file (I don't have the exact filepath in front of me, but you should be able to find it if you search inside platforms/android/). Look for READ_EXTERNAL_PERMISSION permission being declared.

Sorry for being a bit vague in what to look for, I don't have a laptop in front of me at the moment. Alternatively, you can paste the 'AndroidManifest.xml` here so that I can take a look.

[azizbohra]

Here is my AndroidManifest.xml file and i can see read & write permission is there

<?xml version='1.0' encoding='utf-8'?> <manifest android:hardwareAccelerated="true" android:versionCode="10004" android:versionName="1.0.4" package="com.*.*" xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools"> <supports-screens android:anyDensity="true" android:largeScreens="true" android:normalScreens="true" android:resizeable="true" android:smallScreens="true" android:xlargeScreens="true" /> <uses-permission android:name="android.permission.INTERNET" /> <application android:hardwareAccelerated="true" android:icon="@mipmap/round_icon" android:label="@string/app_name" android:supportsRtl="true" android:theme="@style/doneoTheme"> <activity android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale" android:label="@string/activity_name" android:launchMode="singleTask" android:name="MainActivity" android:screenOrientation="portrait" android:theme="@style/doneoTheme" android:windowSoftInputMode="adjustResize"> <intent-filter android:label="@string/launcher_name"> <action android:name="android.intent.action.MAIN" /> <category android:name="android.intent.category.LAUNCHER" /> </intent-filter> <intent-filter> <action android:name="android.intent.action.VIEW" /> <category android:name="android.intent.category.DEFAULT" /> <category android:name="android.intent.category.BROWSABLE" /> <data android:scheme="mostashari" /> </intent-filter> <intent-filter android:autoVerify="true"> <action android:name="android.intent.action.VIEW" /> <category android:name="android.intent.category.DEFAULT" /> <category android:name="android.intent.category.BROWSABLE" /> <data android:host="mostashari.com" android:pathPrefix="/" android:scheme="https" /> <data android:host=" " android:pathPrefix="/" android:scheme=" " /> <data android:host=" " android:pathPrefix="/" android:scheme=" " /> <data android:host=" " android:pathPrefix="/" android:scheme=" " /> <data android:host=" " android:pathPrefix="/" android:scheme=" " /> </intent-filter> </activity> <provider android:authorities="${applicationId}.provider" android:exported="false" android:grantUriPermissions="true" android:name="org.apache.cordova.camera.FileProvider"> <meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/camera_provider_paths" /> </provider> <provider android:authorities="${applicationId}.opener.provider" android:exported="false" android:grantUriPermissions="true" android:name="io.github.pwlin.cordova.plugins.fileopener2.FileProvider"> <meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/opener_paths" /> </provider> <receiver android:enabled="true" android:name="nl.xservices.plugins.ShareChooserPendingIntent"> <intent-filter> <action android:name="android.intent.action.SEND" /> </intent-filter> </receiver> <provider android:authorities="${applicationId}.sharing.provider" android:exported="false" android:grantUriPermissions="true" android:name="nl.xservices.plugins.FileProvider"> <meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/sharing_paths" /> </provider> <activity android:exported="true" android:name="com.adobe.phonegap.push.PushHandlerActivity" android:permission="${applicationId}.permission.PushHandlerActivity" /> <receiver android:name="com.adobe.phonegap.push.BackgroundActionButtonHandler" /> <receiver android:name="com.adobe.phonegap.push.PushDismissedHandler" /> <service android:name="com.adobe.phonegap.push.FCMService"> <intent-filter> <action android:name="com.google.firebase.MESSAGING_EVENT" /> </intent-filter> </service> <service android:name="com.adobe.phonegap.push.PushInstanceIDListenerService"> <intent-filter> <action android:name="com.google.firebase.INSTANCE_ID_EVENT" /> </intent-filter> </service> <meta-data android:name="com.facebook.sdk.ApplicationId" android:value="@string/fb_app_id" /> <meta-data android:name="com.facebook.sdk.ApplicationName" android:value="@string/fb_app_name" /> <activity android:configChanges="keyboard|keyboardHidden|screenLayout|screenSize|orientation" android:label="@string/fb_app_name" android:name="com.facebook.FacebookActivity" /> </application> <uses-sdk android:minSdkVersion="19" android:targetSdkVersion="27" /> <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" /> <uses-permission android:name="android.permission.BLUETOOTH" /> <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" /> <uses-permission android:name="android.permission.WAKE_LOCK" /> <uses-permission android:name="android.permission.VIBRATE" /> <uses-permission android:name="android.permission.RECORD_AUDIO" /> <uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS" /> <uses-permission android:name="android.permission.READ_PHONE_STATE" /> </manifest>

[breautek]

Unfortunately I'm unable to reproduce the issue using an emulator or any real devices that I have access to. This doesn't mean the issue doesn't exist obviously, My devices that have an SD card slot are old and aren't running the same OS version as you. This issue may be device specific. I was using the test app that you provided to do my tests.

Also worth noting that on my device, the sdcard path looks like file:///storage/extSdCard/ and not file://scard/ as shown in the original bug report. This may be confusing because the docs makes it appear like it should be /sdcard/.

[azizbohra]

Hello @breautek ,

I have tested the same app on Xiaomi M1 A1 having AndroidOne OS and getting the same issue while resolving local file system URL by (resolveLocalFileSystemURL). Even getting same issue on Samsung A7, A20, Note8, Huawei etc

But the twist is here that, I was testing day before yesterday and it was working file but now it is not working. The native URL i am getting is the same as before but when i am resolving native URL by resolveLocalFileSystemURL to get fileentry, it is throwing error NOT_FOUND error code 1. Even the app has storage permissions (Read & Write), but still not able to access it.

Second thing is very interesting, let me explain you in detail.
Let's consider an example.
Put one file in internal storage with name image1.png
Put second file in external storage (sdcard) with name image2.png

Now try to access that file.
when you select file from internal storage, it will give native URL like file:///storage/emulated/0/image1.png and it will be resolvable by resolveLocalFileSystemURL function.

when you select file from external storage (sdcard), it will give native URL like file:///sdcard/image2.png and it will not be resolvable by resolveLocalFileSystemURL function.

Now change the file name in internal storage from image1.png to image2.png. When you select file from external storage you will get same native URL file:///sdcard/image1.png, but now it will be resolvable by resolveLocalFileSystemURL

The conclusion is resolveLocalFileSystemURL is searching file only in internal storage even if the path is different. But it was supposed to search file on external storage (sdcard).

I am searching for a solution. Please help me bro.

[breautek]

Ok so, if I understand correctly, the issue occurs when you have 2 identical filenames, one on the internal storage, and the other on the external storage.

Then if you use resolveLocalFileSystemURL on the sdcard file, it will fail?

In my testing, my sdcard/internal storage definitely didn't had two of the same files with the files I was testing with. So later tonight I can try again with this kind of environment.

[azizbohra]

@breautek

No i mean to say, if you have same file on internal or external device storage then it will work because in the both the cases resolveLocalFileSystemURL is searching only in internal storage.

If you don't have same file on external or internal then it will not work. It will work only if you are selecting file from internal storage.

The conclusion is, in both the cases it is not working at all with external storage.
resolveLocalFileSystemURL throwing an error NOT_FOUND !!!!!!

Just now i have tested it on Galaxy Note3 and it is working fine. It is giving me this file:///storage/extSdCard/ URL for external storage files.

[breautek]

Just now i have tested it on Galaxy Note3 and it is working fine. It is giving me this file:///storage/extSdCard/ URL for external storage files.

On my device that has an sdcard slot, this is what the path also looks like for me.

I'm not familiar with this codebase, but I'll take a look to see if I can find any bad assumptions... But I can only do this later tonight unfortunately. Of course you are more than welcome to poke around the native code yourself and add logging to the native code to try to find any discrepancies between the phones that do work vs the phones that don't work.

So far the pattern appears to be phones that provide a file:///sdcard/ path doesn't work, but phones that provide a file:///storage/extSdCard/ does work. I don't have access to a device that produces a file:///sdcard/ path, so if the pattern is related then I won't be able to reproduce and therefore I cannot be confident if I make any changes, it will actually solve any issue.

The method in question is located at

cordova-plugin-file/src/android/FileUtils.java

Line 707 in 74a4646

private JSONObject resolveLocalFileSystemURI(String uriString) throws IOException, JSONException {

This is probably the area of interest:

cordova-plugin-file/src/android/FileUtils.java

Lines 721 to 735 in 74a4646

	try {
	Filesystem fs = this.filesystemForURL(inputURL);
	if (fs == null) {
	throw new MalformedURLException("No installed handlers for this URL");
	}
	if (fs.exists(inputURL)) {
	if (!isNativeUri) {
	// If not already resolved as native URI, resolve to a native URI and back to
	// fix the terminating slash based on whether the entry is a directory or file.
	inputURL = fs.toLocalUri(fs.toNativeUri(inputURL));
	}
	return fs.getEntryForLocalURL(inputURL);
	}
	} catch (IllegalArgumentException e) {

If it doesn't enter the if (fs.exists(inputURL)) { block, then it will end up throwing a file not found error.

[azizbohra]

I am not sure about that, I think file:///sdcard & file:///storage/extSdCard/ both are working but on few devices resolveLocalFileSystemURL throwing an error NOT_FOUND.

[breautek]

This issue may be related to

https://issues.apache.org/jira/browse/CB-10883

Which has a pending PR for a fix for #173, but currently it is in a conflicted state and had no activity for a year.

The Jira issue states that this is an issue starting from Android 6 and above, which will explain why I couldn't reproduce the issue on my test device.

I found my work's android 6 device, so I'll bring that home tonight and test using that device.

[breautek]

Just tested with the Samsung Galaxy s5, running Android 6. I have a sopy of images stored in both the internal storage and sd card but I'm still unable to reproduce the issue.

Internal storage path: file:///storage/emulated/0/Pictures/Screenshots/Screenshot_2018-01-12-16-11-26.png

SD Card: file:///storage/661F-EA5B/Screenshot_2018-01-12-16-11-26.png
SD Card: file:///storage/661F-EA5B/Pictures/Screenshots/Screenshot_2018-01-12-16-11-26.png

[breautek]

@azizbohra You can try running logcat to find out more information Perhaps using:

adb logcat *:S *:W *:E

Which will silent all logs except for warnings and errors.

You can also look in the source files for TAG or LOG_TAG strings and filter by them by doing:

adb logcat *:S *:W *:E <tag1> <tag2>