Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ function, which is typically less customizable.
- Android
- Browser
- iOS
- Windows

## navigator.notification.confirm

Expand Down Expand Up @@ -127,20 +126,13 @@ indexing, so the value is `1`, `2`, `3`, etc.
- Android
- Browser
- iOS
- Windows

### Android Quirks

- Android supports a maximum of three buttons, and ignores any more than that.

- Android dialog title cannot exceed 2 lines of content, it will ignore any more than this.

### Windows Quirks

- On Windows8/8.1 it is not possible to add more than three buttons to MessageDialog instance.

- On Windows Phone 8.1 it's not possible to show dialog with more than two buttons.

## navigator.notification.prompt

Displays a native dialog box that is more customizable than the browser's `prompt` function.
Expand Down Expand Up @@ -188,18 +180,13 @@ contains the following properties:
- Android
- Browser
- iOS
- Windows

### Android Quirks

- Android supports a maximum of three buttons, and ignores any more than that.

- On Android 3.0 and later, buttons are displayed in reverse order for devices that use the Holo theme.

### Windows Quirks

- On Windows prompt dialog is html-based due to lack of such native api.

## navigator.notification.beep

The device plays a beep sound.
Expand All @@ -218,7 +205,6 @@ The device plays a beep sound.
- Android
- Browser
- iOS
- Windows 8

### Android Quirks

Expand Down
6 changes: 2 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
"platforms": [
"android",
"browser",
"ios",
"windows"
"ios"
]
},
"repository": "github:apache/cordova-plugin-dialogs",
Expand All @@ -20,8 +19,7 @@
"ecosystem:cordova",
"cordova-android",
"cordova-browser",
"cordova-ios",
"cordova-windows"
"cordova-ios"
],
"scripts": {
"test": "npm run lint",
Expand Down
9 changes: 0 additions & 9 deletions plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,4 @@
<resource-file src="src/ios/CDVNotification.bundle" />
<framework src="AudioToolbox.framework" weak="true" />
</platform>

<!-- windows -->
<platform name="windows">
<js-module src="src/windows/NotificationProxy.js" name="NotificationProxy">
<runs />
</js-module>

<asset src="www/windows/notification.css" target="css/notification.css" />
</platform>
</plugin>
275 changes: 0 additions & 275 deletions src/windows/NotificationProxy.js

This file was deleted.

7 changes: 2 additions & 5 deletions tests/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -215,13 +215,10 @@ exports.defineManualTests = function (contentEl, createActionButton) {
'alert'
);

// WP8.1 detection is necessary since it doesn't support confirm dialogs with more than 2 buttons
var isRunningOnWP81 = cordova.platformId === 'windows' && navigator.userAgent.indexOf('Windows Phone') > -1;

createActionButton(
'Confirm Dialog - Deprecated',
function () {
var buttons = isRunningOnWP81 ? 'Yes,No' : 'Yes,No,Maybe';
var buttons = 'Yes,No,Maybe';
confirmDialogA('You pressed confirm.', 'Confirm Dialog', buttons);
},
'confirm_deprecated'
Expand All @@ -230,7 +227,7 @@ exports.defineManualTests = function (contentEl, createActionButton) {
createActionButton(
'Confirm Dialog',
function () {
var buttons = isRunningOnWP81 ? ['Yes', 'Actually, No'] : ['Yes', 'No', 'Maybe, Not Sure'];
var buttons = ['Yes', 'No', 'Maybe, Not Sure'];
confirmDialogB('You pressed confirm.', 'Confirm Dialog', buttons);
},
'confirm'
Expand Down
2 changes: 1 addition & 1 deletion www/notification.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ function convertButtonLabels (buttonLabels) {
// Some platforms take an array of button label names.
// Other platforms take a comma separated list.
// For compatibility, we convert to the desired type based on the platform.
if (platform.id === 'android' || platform.id === 'ios' || platform.id === 'windows') {
if (platform.id === 'android' || platform.id === 'ios') {
if (typeof buttonLabels === 'string') {
buttonLabels = buttonLabels.split(','); // not crazy about changing the var type here
}
Expand Down
Loading
Loading