Draft implementation for Unified platform API #226
Conversation
`platforms` property now returns array of platforms APIs
* Renames common methods' names to be more JS-y * Provides mapping from old names -> new ones to smooth transition
* Moves compat-related functionality to separate section * Adds more comments for better understanding
| value: new ParserHelper(this.platform), | ||
| enumerable: true, | ||
| configurable: false, | ||
| writable: false |
There was a problem hiding this comment.
The writeable/configurable:false, has the tendency to interfere with jasmine spies which causes our tests to fail with very obscure error messages. Just in case you encounter such errors, otherwise I'm all for leaving this as false.
There was a problem hiding this comment.
We can always change behavior of parser if we'll have any problems later so i would prefer to leave it as-is.
|
Looks great! |
| PlatformHandler.prototype.updateWww = function() { | ||
| var projectRoot = util.isCordova(this.root); | ||
| var appWww = util.projectWww(projectRoot); | ||
| var platformWww = path.join(this.root, 'platform_www'); |
There was a problem hiding this comment.
Looks like we would like to avoid using util.isCordova() here. One can easily create single platform projects that do not maintain the traditional Cordova Project directory structure. Kind of like it was with plugman based workflow or with my latests attempts at the gulp based workflow.
Myabe just pass the appWww as a parameter to this function, and for now as a compatibility feature, get it from util.isCordova() if it's not provided.
|
Yeah, reworking tests will be painful. |
Draft implementation of Unified Platform API for cordova, that inspired by this thread in cordova-dev mailing list and this proposal