feat!: support previous non-E2E #1817
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
+ Coverage 72.24% 72.75% +0.51%
==========================================
Files 23 23
Lines 1841 1828 -13
==========================================
Hits 1330 1330
+ Misses 511 498 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dpogue
reviewed
Jun 27, 2025
|
You might be able to use |
erisu
force-pushed
the
feat/non-e2e-and-improved-system-bar-theming
branch
from
b4e4b54 to
250a0c6
Compare
erisu
changed the title
erisu
force-pushed
the
feat/non-e2e-and-improved-system-bar-theming
branch
from
250a0c6 to
7859c97
Compare
erisu
force-pushed
the
feat/non-e2e-and-improved-system-bar-theming
branch
from
56fff49 to
7184110
Compare
dpogue
reviewed
Jul 9, 2025
dpogue
approved these changes
Jul 9, 2025
wmathurin
added a commit
to wmathurin/SalesforceMobileSDK-Package
that referenced
this pull request
Jul 10, 2025
…n Android API 35 Overriding Cordova's default themes for API 35 NB: It looks like better E2E support is coming to Cordova Android 15 - see apache/cordova-android#1817
|
Last call for any additional reviews. Will be merged in tomorrow. |
|
Is this PR intended to make the current statusbar plug-in deprecated in the future? We currently use the config StatusBarOverlaysWebView from that plugin. If the plug-in is to be deprecated, will you include this option in each platform? |
erisu
force-pushed
the
feat/non-e2e-and-improved-system-bar-theming
branch
from
2fbdc58 to
bfa1941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
StatusBar JS API:
window.statusbar.visible = <true|false>window.statusbar.setBackgroundColor('#AARRGGBB')`config.xml preferences:
This PR reuses all of the previous preferences. Order of imports listed below
StatusBarBackgroundColorBackgroundColorBackgroundColorTesting
npm tChecklist
(platform)if this change only applies to one platform (e.g.(android))