GH-109: Implement Vector Validators for StringView #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViggoC
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
lidavidm
reviewed
Oct 26, 2025
Comment on lines
162
to
165
| validateOrThrow( | ||
| vector.getValueCount() >= 0, | ||
| "Vector valueCount %s is negative.", | ||
| vector.getValueCapacity()); |
There was a problem hiding this comment.
Can we use validateVectorCommon?
The comment in validateVectorCommon points back to #109. So I feel like figuring that out should be part of resolving the issue.
There was a problem hiding this comment.
How do you think validateVectorCommon should be modified to support StringView? My idea is
if (vector instanceof BaseVariableWidthViewVector) {
int typeBufferCount = TypeLayout.getTypeBufferCount(arrowType);
validateOrThrow(
fieldVector.getFieldBuffers().size() >= typeBufferCount,
"Expected at least %s buffers in vector of type %s, got %s.",
typeBufferCount,
vector.getField().getType().toString(),
fieldVector.getFieldBuffers().size());
} There was a problem hiding this comment.
Roughly yes but I would prefer adding a TypeLayout.isVariableBuffer instead of hardcoding a type check
lidavidm
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Implement Vector Validators for StringView.
Closes #109.