Esc as interrupt #155
Open
Esc as interrupt #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, works fine on Windows 11. Hope it will get merged |
|
Cool, but it's not cross-platform. This excludes macos and linux users. I am saying this, because this PR is a great idea... but, it breaks other builds. (I just looked it up, to verify that before saying anything.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with using CTRL+C to interrupt prediction. The second CTRL+C would always close the application. This fix adds a check for the ESC key and sets the is_interactive variable to true when detected. This will force the program to return to interactive mode after the current prediction.