Return camera position is optional in general plotter #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #865 +/- ##
==========================================
+ Coverage 58.08% 58.22% +0.14%
==========================================
Files 172 172
Lines 10560 10586 +26
==========================================
+ Hits 6134 6164 +30
+ Misses 4426 4422 -4 |
|
Ha! Code coverage (check) is excellent. |
akaszynski
reviewed
Jan 31, 2022
akaszynski
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #863 by implementing
return_cposoptional keyword.I also added the option that if no output is request, it will return
None. I think it is more pythonic.