Skip to content

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 28, 2022

Small improvements on the converter.

Points addressed:

  • Improved compatibility with Mechanical ds.dat output file.
  • Improved coverage
  • Small general improvements.

Close #808

@germa89 germa89 self-assigned this Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #862 (ea0fc45) into main (057e645) will increase coverage by 0.91%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
+ Coverage   58.31%   59.22%   +0.91%     
==========================================
  Files         172      172              
  Lines       10595    10640      +45     
==========================================
+ Hits         6178     6302     +124     
+ Misses       4417     4338      -79     

@germa89 germa89 marked this pull request as draft January 28, 2022 02:36
@akaszynski
Copy link
Collaborator

I'll be fixing the docs build in in a #861. Hold of working on this or fixing the docs.

@germa89 germa89 marked this pull request as ready for review January 28, 2022 20:30
@germa89
Copy link
Collaborator Author

germa89 commented Jan 28, 2022

@akaszynski in my case the building was failing because of format issues (forgot to backscape).

@germa89 germa89 marked this pull request as draft January 28, 2022 20:31
@germa89
Copy link
Collaborator Author

germa89 commented Jan 28, 2022

I'm still investigating the issues about the "-1".

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, and great unit testing.

Made several changes, all style except for adding autopep8 to our test requirements so we can test if autopep8 works.

@germa89
Copy link
Collaborator Author

germa89 commented Feb 1, 2022

Thank you Alex.

Apologies for the style errors, I should be more careful with those.

@germa89 germa89 merged commit bcbe0cd into main Feb 1, 2022
@germa89 germa89 deleted the fix/improving-converter branch February 1, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Converter_script does not work well with Mechanical ds.dat

2 participants