-
Notifications
You must be signed in to change notification settings - Fork 139
Fix/improving converter #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #862 +/- ##
==========================================
+ Coverage 58.31% 59.22% +0.91%
==========================================
Files 172 172
Lines 10595 10640 +45
==========================================
+ Hits 6178 6302 +124
+ Misses 4417 4338 -79 |
I'll be fixing the docs build in in a #861. Hold of working on this or fixing the docs. |
@akaszynski in my case the building was failing because of format issues (forgot to backscape). |
I'm still investigating the issues about the "-1". |
Co-authored-by: Alex Kaszynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, and great unit testing.
Made several changes, all style except for adding autopep8
to our test requirements so we can test if autopep8
works.
Thank you Alex. Apologies for the style errors, I should be more careful with those. |
Small improvements on the converter.
Points addressed:
ds.dat
output file.Close #808