Fix processing RoomDatabases with non dao functions and properties #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate bot
referenced
this pull request
in sindrenm/android-project-template
Sep 21, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [se.ansman.dagger.auto:compiler](https://redirect.github.com/ansman/auto-dagger) | `1.3.0` -> `1.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [se.ansman.dagger.auto:android](https://redirect.github.com/ansman/auto-dagger) | `1.3.0` -> `1.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ansman/auto-dagger (se.ansman.dagger.auto:compiler)</summary> ### [`v1.4.0`](https://redirect.github.com/ansman/auto-dagger/releases/tag/1.4.0) [Compare Source](https://redirect.github.com/ansman/auto-dagger/compare/1.3.0...1.4.0) ##### New features ##### Kotlin 2.0 auto-dagger now uses 2.0.20 and KSP 2.0.20-1.0.25. K2/KSP2 is however not supported yet due to Dagger not supporting K2/KSP2. ##### Min SDK 21 The AndroidX libraries now require a minimum SDK version of 21. This matches what AndroidX now requires. ##### `@Generated` annotation All generated types now add the `@Generated` annotation. This means that you must target Java 9 or higher to use auto-dagger. ##### Bug fixes ##### Fix a bug with room processing If your Room database class contained anything except Daos, auto-dagger would incorrectly generate providers for them and if the return type was generic, then the class would fail to process. This has been fixed and only Daos will be provided. ##### Details - Bump androidx.lifecycle:lifecycle-viewmodel from 2.8.4 to 2.8.5 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/ansman/auto-dagger/pull/216](https://redirect.github.com/ansman/auto-dagger/pull/216) - Bump com.android.tools.build:gradle from 8.5.2 to 8.6.0 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/ansman/auto-dagger/pull/214](https://redirect.github.com/ansman/auto-dagger/pull/214) - Update Gradle Wrapper from 8.10 to 8.10.1 by [@​ansman-gradle-wrapper-update](https://redirect.github.com/ansman-gradle-wrapper-update) in [https://github.com/ansman/auto-dagger/pull/218](https://redirect.github.com/ansman/auto-dagger/pull/218) - Bump com.squareup.okio:okio from 3.9.0 to 3.9.1 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/ansman/auto-dagger/pull/219](https://redirect.github.com/ansman/auto-dagger/pull/219) - Bump com.android.tools.build:gradle from 8.6.0 to 8.6.1 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/ansman/auto-dagger/pull/220](https://redirect.github.com/ansman/auto-dagger/pull/220) - Bump androidx.lifecycle:lifecycle-viewmodel from 2.8.5 to 2.8.6 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/ansman/auto-dagger/pull/222](https://redirect.github.com/ansman/auto-dagger/pull/222) - Downgrade to Gradle 8.10 by [@​ansman](https://redirect.github.com/ansman) in [https://github.com/ansman/auto-dagger/pull/226](https://redirect.github.com/ansman/auto-dagger/pull/226) - Update android min SDK to 21 by [@​ansman](https://redirect.github.com/ansman) in [https://github.com/ansman/auto-dagger/pull/228](https://redirect.github.com/ansman/auto-dagger/pull/228) - Bump androidx.startup:startup-runtime from 1.1.1 to 1.2.0 by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/ansman/auto-dagger/pull/223](https://redirect.github.com/ansman/auto-dagger/pull/223) - Update to Kotlin 2.0.20 by [@​ansman](https://redirect.github.com/ansman) in [https://github.com/ansman/auto-dagger/pull/227](https://redirect.github.com/ansman/auto-dagger/pull/227) - Add `@Generated` to all generated classes by [@​ansman](https://redirect.github.com/ansman) in [https://github.com/ansman/auto-dagger/pull/225](https://redirect.github.com/ansman/auto-dagger/pull/225) - Fix processing RoomDatabases with non dao functions and properties by [@​ansman](https://redirect.github.com/ansman) in [https://github.com/ansman/auto-dagger/pull/229](https://redirect.github.com/ansman/auto-dagger/pull/229) **Full Changelog**: ansman/auto-dagger@1.3.0...1.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/sindrenm/android-project-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibGlicyJdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #224