-
Notifications
You must be signed in to change notification settings - Fork 22
feat: support for w3c v2 and async issuance #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Henrique Dias <[email protected]>
| ...deferredCredentialResponse, | ||
| ...accessToken, | ||
| issuerMetadata, | ||
| verifyCredentialStatus: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just used the same option as we do when fetching normal credentials. So... whoever implemented it initially should have more background on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm interesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should only verify the first of a batch ... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/easypid/src/features/receive/DeferredCredentialNotificationScreen.tsx
Outdated
Show resolved
Hide resolved
apps/easypid/src/features/receive/FunkeOpenIdCredentialNotificationScreen.tsx
Outdated
Show resolved
Hide resolved
apps/easypid/src/features/receive/slides/CredentialRetrievalSlide.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Henrique Dias <[email protected]>
|
did you use thte AI instruction to generate the translations? |
Yes |
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Henrique Dias <[email protected]>
|
@TimoGlastra I updated the PR with some fixes for the dependencies and the following changes:
|
|
Awesome, the new screenshots look great. Ddi you address the hook error as well? |
|
@TimoGlastra just pushed that fix :D |
|
I'm merging this one into |

This PR adds support for:
mainversion of the Playground.Things still to do/fix:
Some screenshots related to async issuance: