Skip to content

Conversation

@hacdias
Copy link
Member

@hacdias hacdias commented Sep 29, 2025

This PR adds support for:

  • W3C V2 Credentials: this hasn't been tested, since we don't support this format in our Playground. Assuming the work in Credo works correctly, the wallet implementation should also work correctly. We need to test it.
  • Async Issuance: this has been tested against the main version of the Playground.
  • Translations still need to be added, but I'll do the translation with AI once we have the final English copy.

Things still to do/fix:

  • mDOC presentation
  • mDOC issuance
  • Added credential text doesn't make it clear that it is still pending
  • Make sure text is not truncated with translations on the "Deferred credential notification" page
  • Make called 'deferred' pending in all screens and update translations

Some screenshots related to async issuance:

Adding deferred credential Notification page Notification page with failure
IMG_5046 IMG_5049 IMG_5050
Deleting deferred credential Activity list Notifications list
IMG_5051 IMG_5052 IMG_5048
Adding credential success - -
IMG_5047

@hacdias hacdias requested a review from TimoGlastra September 29, 2025 14:19
...deferredCredentialResponse,
...accessToken,
issuerMetadata,
verifyCredentialStatus: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why false?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just used the same option as we do when fetching normal credentials. So... whoever implemented it initially should have more background on it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm interesting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should only verify the first of a batch ... 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is why:

image

In Credo we fail when we say true, but checking the status is not supported for the specific type of credential.

@TimoGlastra
Copy link
Member

did you use thte AI instruction to generate the translations?

@hacdias
Copy link
Member Author

hacdias commented Oct 3, 2025

did you use thte AI instruction to generate the translations?

Yes

@hacdias
Copy link
Member Author

hacdias commented Oct 16, 2025

@TimoGlastra I updated the PR with some fixes for the dependencies and the following changes:

  • Wording around the "deferred credentials" is changed to "pending card" for simplicity and matches the rest
  • Translations updated
  • The truncation problem is fixed
  • Tested mDOC issuance & presentation and both seem to work
  • Updated the added text to make clear that it is deferred
  • Updated screenshots above to match updates

@TimoGlastra
Copy link
Member

Awesome, the new screenshots look great. Ddi you address the hook error as well?

@hacdias
Copy link
Member Author

hacdias commented Oct 16, 2025

@TimoGlastra just pushed that fix :D

@hacdias
Copy link
Member Author

hacdias commented Oct 16, 2025

I'm merging this one into feat/latest-credo. We can see how to go from there.

@hacdias hacdias merged commit 534d205 into feat/latest-credo Oct 16, 2025
@hacdias hacdias deleted the feat/async-issuance branch October 16, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants