Skip to content

fix(focus-trap): import rxjs first operator #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2017
Merged

fix(focus-trap): import rxjs first operator #4400

merged 1 commit into from
May 11, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented May 5, 2017 •
edited
Loading

  • The first operator from RxJS is being used by the FocusTrap to subscribe to a NgZone EventEmitter. The first operator isn't imported and compiling & using core as a standalone would fail.

screen shot 2017-05-05 at 19 26 18

Note: More PR's like that to expect. Recognizable when doing the new packaging.

@devversion
fix(focus-trap): import rxjs first operator
9d21e33 
* The `first` operator from RxJS is being used by the FocusTrap to subscribe to a NgZone observable. The `first` operator isn't imported and compiling & using core as a standalone would fail.
@devversion devversion requested a review from jelbourn May 5, 2017 17:29
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 5, 2017
@devversion devversion mentioned this pull request May 6, 2017
Merged
jelbourn
jelbourn approved these changes May 10, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Small chance this will have a presubmit error, we'll see

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 10, 2017
@kara kara merged commit 2c8faf6 into angular:master May 11, 2017
@devversion devversion deleted the fix/focus-trap-rxjs-first branch November 11, 2017 10:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @kara @googlebot