fix(select): missing rxjs filter import #4407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `filter` RxJs operator is being used inside of the select. Building the select package on its own would not work because the `filter` operator is not present. The failures just don't show up because in some other packages we import the `filter` operator and it will be applied to the global Observable prototype.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
filterRxJs operator is being used inside of the select. Building the select package on its own would not work because thefilteroperator is not present.The failures just don't show up because in some other packages we import the
filteroperator and it will be applied to the global Observable prototype.Note: This appears when building the different secondary entry-points on its own.
Related to #4400