refactor(focus-trap): better handling of server-side rendering #8519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
approved these changes
Nov 17, 2017
mmalerba
added
pr: lgtm
action: merge
jelbourn
reviewed
Nov 17, 2017
src/cdk/a11y/focus-trap.ts
Outdated
| private _platform: Platform, | ||
| private _checker: InteractivityChecker, | ||
| private _ngZone: NgZone, | ||
| private _document: any, |
Member
There was a problem hiding this comment.
I'm not really happy with the propagation of any from this pattern. I just tried this locally and it works:
private _document: Document;
class Whatever {
constructor(@Optional() @Inject(DOCUMENT) doc: any) {
this._document = doc;
}
}It's a little more boilerplate but I think it's worth it. Start doing this instead?
Member
Author
There was a problem hiding this comment.
Makes sense. I'll switch these changes over.
Now that Angular is using Domino, we don't have to completely shut off the focus trap when rendering on the server. These changes remove all the old checks and use the correct document injection token.
crisbeto
force-pushed
the
focus-trap-ssr
branch
from
5509460 to
c8d2c1e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Angular is using Domino, we don't have to completely shut off the focus trap when rendering on the server. These changes remove all the old checks and use the correct document injection token.