Fixing memory leak for expansion-panel (#8403) #8410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 13, 2017
| } | ||
|
|
||
| ngOnDestroy() { | ||
| super.ngOnDestroy(); |
Member
There was a problem hiding this comment.
Can you add a unit test for this change?
Contributor
Author
There was a problem hiding this comment.
I really tried to come up with a unit test, but I have not written unit tests for Jasmin/Karma before so I didnt really get it to work.
This is what I came up with but chrome hangs during execution:
it('make sure accordion item runs ngOnDestroy when expansion panel is destroyed', () => {
let fixture = TestBed.createComponent(PanelWithContent);
spyOn(fixture.componentInstance.panel.destroyed, 'emit');
fixture.componentInstance.panel.ngOnDestroy();
fixture.detectChanges();
expect(fixture.componentInstance.panel.destroyed.emit).toHaveBeenCalled();
});
Contributor
Author
There was a problem hiding this comment.
Ok, so I think I managed to make a correct unit test finally.
josephperrott
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to replace (#8404), please check this for more information.