Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 1, 2017

Currently the Angular 5 dependency is set to rc.9. Bumps it to the final version.

Currently the Angular 5 dependency is set to rc.9. Bumps it to the final version.
@crisbeto crisbeto added the in progress This issue is currently in progress label Nov 1, 2017
@crisbeto crisbeto self-assigned this Nov 1, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 1, 2017
@crisbeto crisbeto added pr: needs review and removed in progress This issue is currently in progress labels Nov 1, 2017
@crisbeto crisbeto assigned andrewseguin and unassigned crisbeto Nov 1, 2017
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 1, 2017
"@angular/compiler-cli": "^5.0.0",
"@types/node": "^6.0.42",
"ts-node": "1.2.1",
"typescript": "~2.2.1"
Copy link

@vitaly-t vitaly-t Nov 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we up the TypeScript to 2.5.3 at this point? 😉

And perhaps rxjs to 5.5.2? ts-node is also too out-of date, current is 3.3.0

@angular/cli should be also 1.5.0 now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS should at least be 2.3? Since ng 5 uses some feature from it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another PR that fixes the TS version for the screenshot tool.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants