-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: bump to Angular 5 final #8177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently the Angular 5 dependency is set to rc.9. Bumps it to the final version.
andrewseguin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| "@angular/compiler-cli": "^5.0.0", | ||
| "@types/node": "^6.0.42", | ||
| "ts-node": "1.2.1", | ||
| "typescript": "~2.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we up the TypeScript to 2.5.3 at this point? 😉
And perhaps rxjs to 5.5.2? ts-node is also too out-of date, current is 3.3.0
@angular/cli should be also 1.5.0 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TS should at least be 2.3? Since ng 5 uses some feature from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another PR that fixes the TS version for the screenshot tool.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently the Angular 5 dependency is set to rc.9. Bumps it to the final version.