Skip to content

chore: fix lint error #8136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2017
Merged

chore: fix lint error #8136

merged 1 commit into from
Oct 30, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 30, 2017 •
edited
Loading

Fixes a few linting errors

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2017
@crisbeto crisbeto changed the title chore: fix test compilation error chore: fix lint error Oct 30, 2017
@crisbeto
chore: fix lint error
19a4ff4 
Fixes a few linting errors
jelbourn
jelbourn approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 30, 2017
@crisbeto crisbeto force-pushed the table-test-compilation-error branch from e779b89 to 19a4ff4 Compare October 30, 2017 21:57
@jelbourn
Copy link
Member

jelbourn commented Oct 30, 2017

Mared as safe because the only non-test change is adding a semi-colon

@mmalerba mmalerba merged commit b39202f into angular:master Oct 30, 2017
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @mmalerba